Conversation
Previously if a svg directive didn't find an icon the build would fail with a `java.util.NoSuchElementException` but without any indication of what file the bad lookup happen in. By using an Either and Laika's Directive's `evalMap` we get nicer build errors with file names and locations.
valencik
commented
Mar 29, 2026
| def apply( | ||
| latex: String, | ||
| displayMode: Boolean = false | ||
| ): Either[String, String] = |
Member
Author
There was a problem hiding this comment.
Should this perhaps no longer be apply and instead be something like parse or render?
Member
There was a problem hiding this comment.
Yeah, I'd say so -- once it's becoming effectful (which this kind of is), apply doesn't feel quite idiomatically right any more.
Member
Author
There was a problem hiding this comment.
Agreed, renamed to render
Member
Author
|
Let's merge #584 first, and then I'll fix conflicts here. |
jducoeur
approved these changes
Mar 29, 2026
| def apply( | ||
| latex: String, | ||
| displayMode: Boolean = false | ||
| ): Either[String, String] = |
Member
There was a problem hiding this comment.
Yeah, I'd say so -- once it's becoming effectful (which this kind of is), apply doesn't feel quite idiomatically right any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Now when we have bad LaTeX source in a post we surface the KaTeX parse error: